search

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 628 forks source link

Adding custom auth provider not working #747

Open Ptosiek opened 7 years ago

Ptosiek commented 7 years ago

Since commit https://github.com/ASKBOT/askbot-devel/pull/720/commits/68a2f8b546ddd9541efcafc3751c11efe41ba2a9, adding a custom provider is not working. In django_authopenis.utils 'providers' was replaced by an OrderectDict but add_custom_provider tries to insert the provider in the dict (line 381) providers.insert(mod.order_number - 1, mod.name, mod.as_dict()) Quick fix would be replacing with: providers[mod.name]= mod.as_dict() But the ability to specify the ordering is lost this way, not sure if needed though..

martin-bts commented 5 years ago

This was fixed in the 0.11.x branch with https://github.com/ASKBOT/askbot-devel/commit/78cc354ed809d457a35b8082d3860995d10d00d8 and https://github.com/ASKBOT/askbot-devel/commit/2faccae0e750119fec6460b830a7669decd0fe13