search

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

Colliding libraries, django-kombu #794

Closed martin-bts closed 5 years ago

martin-bts commented 5 years ago

Askbot demands django-kombu==0.9.4. However, django-kombu has been merged into kombu with its 2.0.0 release. When i install Askbot / run tox, my system installs kombu==3.0.37 which probably includes django-kombu.

evgenyfadeev commented 5 years ago

Hi Martin,

Yes it's a good idea - as long as the test cases pass:). Thank you!

Evgeny.

On Sun, Jun 16, 2019 at 6:38 PM Martin notifications@github.com wrote:

Askbot demands django-kombu==0.9.4. However, django-kombu has been merged into kombu with its 2.0.0 release. When i install Askbot / run tox, my system installs kombu==3.0.37 which probably includes django-kombu.

  • Which code will be loaded?
  • Can we simply drop the django-kombu==0.9.4?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ASKBOT/askbot-devel/issues/794?email_source=notifications&email_token=AAAY5AVBWM7XCKIIUYDYL6DP226GLA5CNFSM4HYSFD72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZYQ6IQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAY5AR3W74CWB6E3MJSXNLP226GLANCNFSM4HYSFD7Q .

-- Askbot Valparaiso, Chile skype: evgeny-fadeev

martin-bts commented 5 years ago

We can drop django-kombu https://github.com/martin-bts/askbot-devel/pull/21