search

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

requirements-parser #800

Open sebastian-philipp opened 5 years ago

sebastian-philipp commented 5 years ago

Please make use of https://github.com/davidfischer/requirements-parser

the duplicated requirements.txt is out of sync with the askbot_requirements.txt and keeping them synchronized is a lot of manual work

evgenyfadeev commented 5 years ago

there is askbot/startup_procedures that would need to read the requirements.txt file on every app startup.

It works fine in the dev environment, because it is easy to find the requirements.txt file, but when the package is installed AFAIK the requirements.txt file is not copied into the site-packages.

So in order to switch to relying on requirements.txt and keep the self test behavior, the requirements.txt must be part of the installed askbot module. This seems to be the only blocker to resolving the current issue by using the requirements.txt file as the source of the dependencies.

evgenyfadeev commented 5 years ago

perhaps the requirements.txt file can be generated automatically from askbot/__init__.py:REQUIREMENTS, that would make keeping it up to date easier. The generated file would have a warning on top so that nobody makes changes there.

evgenyfadeev commented 5 years ago

@sebastian-philipp a question - in your branches in https://github.com/martin-bts/askbot-devel/ were you relying on requirements.txt when installing the packages? In that case I will copy the packages versions into askbot/__init__.py, otherwise I'll do the opposite before merging your branches into https://github.com/ASKBOT/askbot-devel/

sebastian-philipp commented 5 years ago

We haven't changed the logic at all. We've just updated the dependencies.