ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

Set last activity when accepting answer #843

Closed DLu closed 4 years ago

DLu commented 4 years ago

I believe this is a bug that is affecting my API endpoint.

This means that my action of accepting the answer is not reflected in the last_activity_at timestamp, which makes it difficult to keep track of which questions don't have accepted answers.

I believe this PR should fix it, but I'm not 100% certain and haven't tested it locally yet.

DLu commented 4 years ago

Thoughts, @martin-bts?

martin-bts commented 4 years ago

So far, I mostly concerned myself with how Askbot is implemented, not so much with what is implemented.

This one liner seems sensible to me, but is this really the only code change required to properly address the issue? I don't know. I can't tell. You will have to convince Evgeny.

evgenyfadeev commented 4 years ago

@DLu will have a look over the weekend, maybe you're right.

DLu commented 4 years ago

:+1: