ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

I think I improved the readme and simplify the docker #860

Open jrichardsz opened 4 years ago

jrichardsz commented 4 years ago

Today I tried to deploy askbot in heroku and/or openshift with no luck due to several problems:

Finally I was able to run a success docker container but with this changes. I didn't touch the core : https://github.com/software-architect-tools/askbot/pull/1

How can I adapt to your standards this PR in order to point to your official repository?

Thanks

evgenyfadeev commented 4 years ago

The issue is that I'm just in the progress of completing the askbot-setup script in the branch supporting python3. Once this script is done it would perhaps make more sense to improve the docker deployment process.

I haven't read your changes yet, will do that some time tomorrow, thank you for being willing to contribute.

jrichardsz commented 4 years ago

Thanks to you for your time.

evgenyfadeev commented 4 years ago

Looks great, thank you for sharing your code, this will be implemented after the askbot-setup is done.

martin-bts commented 3 years ago

Your pull request is not available to me, so I cannot tell from which branch you tried to create a Docker image. The Askbot Python 3 branch, which is now this project's master branch used to contain Dockerfiles that would accept SECRET_KEY and DATABASE_URL as environment variables. Since there is no installer at the moment, I provided a more sophisticated Dockerfile as part of #867 . Maybe this addresses your problem.