search

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

LDAP login error #924

Closed brunobastosg closed 1 year ago

brunobastosg commented 1 year ago

When trying to login via LDAP, I get the following error:

Traceback (most recent call last):
  File "/path/to/my/project/.venv/lib/python3.10/site-packages/askbot/deps/django_authopenid/ldap_auth.py", line 98, in ldap_authenticate_default
    ldap_session.simple_bind_s(
  File "/path/to/my/project/.venv/lib/python3.10/site-packages/ldap/ldapobject.py", line 248, in simple_bind_s
    msgid = self.simple_bind(who,cred,serverctrls,clientctrls)
  File "/path/to/my/project/.venv/lib/python3.10/site-packages/ldap/ldapobject.py", line 242, in simple_bind
    return self._ldap_call(self._l.simple_bind,who,cred,RequestControlTuples(serverctrls),RequestControlTuples(clientctrls))
  File "/path/to/my/project/.venv/lib/python3.10/site-packages/ldap/ldapobject.py", line 128, in _ldap_call
    result = func(*args,**kwargs)
TypeError: simple_bind() argument 1 must be str or None, not bytes

Seems like an easy fix. I'll run some tests and if it works, I'll open a PR.