Add continuous integration tests

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com

Other

1.57k stars 627 forks source link

Add continuous integration tests #938

Closed boxydog closed 6 months ago

boxydog commented 6 months ago

Add tests that run for every github push.

This is a first step to better project health. I'd suggest a lot of things here if there were active development:

moving to pip-tools or some other better package manager
supporting running the unit tests directly from the tree instead of installing first
moving on from the deprecated python setup tools to something supported
fixing the broken unit tests that I commented out (hence fixing or removing lamson)
etc..

P.S. I'd squash-commit this PR, it has lots of little tweaks while I was debugging.

evgenyfadeev commented 6 months ago

Hi, @boxydog thank you! It's ok that there are many commits. I agree on disabling the lamson tests, the other two should be fixable, I'll have a look at them.

boxydog commented 6 months ago

A question: - do the tests actually run with this PR in the github environment?

They do. https://github.com/ASKBOT/askbot-devel/actions

Do you have any interest in me poking at other health-type things? ruff, ruff formatting, pre-commit, stuff like that? It would only be a couple of hours for me to propose a couple things, but only if that seems good to you. Not sure where to discuss this. (github has "discussions" you can enable now?)

I'm looking at this because I was looking at https://github.com/openstreetmap/operations/issues/149. One possibility was to use askbot, and I was trying to figure out if it's healthy. Now I'm just poking out of curiosity.

evgenyfadeev commented 6 months ago

Yes I've merged the PR and saw the tests running, thanks again for that! (I saw them running and deleted my question). Thanks for offering to into making some improvements, I'm open to suggestions certainly. Also I can help you migrate from OSQA if you were interested.

Askbot is a one-person show at the moment, but I maintain and support some Q&A sites and the latest code is used in production. If you need a public-facing site I also have an ML spam filter, based on a small Bert-based model. It could be fine-tuned on your data. I haven't published it yet, but I should.

boxydog commented 6 months ago

I am not involved in openstreetmap, I just came across that issue today while wandering the Internet. However, if you are willing to help them, I suggest mentioning it on https://github.com/openstreetmap/operations/issues/149. Say something like, "I maintain askbot, which is a fork of osqa, and I can help you migrate your data if you wish."

You might be helping them out of a jam. They have the very old osqa (Django 1.6) running help.openstreetmap.org, and have been wondering for years how to update it.

Meanwhile, I might make another PR or two for you that I think might help with code health (e.g, pre-commit, ruff with pyupgrade, django-upgrade and so on). I'll try break it up so it's understandable.

boxydog commented 6 months ago

Also, in this comment they talk about trying to pay you. I don't know if that can actually happen, but I wouldn't rule it out either.