ruff pyupgrade - Githubissues

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com

Other

1.56k stars 627 forks source link

ruff pyupgrade #942

Open boxydog opened 5 months ago

boxydog commented 5 months ago

These are all automated fixes from ruff "PY" (pyupgrade).

Includes more aggressive fixes

boxydog commented 5 months ago

Unit tests passed: https://github.com/boxydog/askbot-devel/actions/runs/7686867150/job/20946232045

evgenyfadeev commented 5 months ago

Thanks! This first pass I'll review manually, so it may take some time (perhaps a week) to merge.

boxydog commented 5 months ago

Sounds good, thanks for letting me know.

Just FYI, I think almost everything is two changes:

string formatting from "%s" % foo to f"{foo}"
super(Class, this) to super()

IMO, the useful part of this change is allowing pyupgrade to run on every PR, so it will keep python usage a bit more standard, and a bit more modern. That is my overall pitch for ruff: it will keep the codebase more standard.