Closed dutkulang closed 1 year ago
Wow this is a big update, thx @DutKulang though it is hard to track the changes via Issues now, keep in mind to either
content
branch so we can review/preview first with existing website changes locally and then closes #XYZ
(will close when merged into main automatically)ok i will create a branch (a copy of main) and push the changes there
I can see lots of changes in the descriptions but not the entire changes of the Profiles according to Issues (as in contacts, Skillsets etc.) are implemented, so do we leave those issues open and deal with it later to have just a quick update on the profiles? @romeoplat @DutKulang
I would merge this on content branch but have not yet double checked the images (<1MB and 1:1 or 1:1.5 ratio) @chardso @DutKulang can you confirm?
@timmwille that particular image is too large, but however i tried to resize it through telegram share, from 5.8mb to 195.2kb Unfortunately the image format changes from jpg to jpeg , won't this affect it displaying on the webpage? If no, i upload the resized one and pullrequest But before dat i would close the existing pullrequest befote sending another one, is it okay!
I can see lots of changes in the descriptions but not the entire changes of the Profiles according to Issues (as in contacts, Skillsets etc.) are implemented, so do we leave those issues open and deal with it later to have just a quick update on the profiles? @romeoplat @DutKulang
That's a yes, we still need to actually ad updates on the skills which I guess I want to do, and also we need to be able to reach out to the members to collect their photos but for lets keep the profiles open.
Ok then we go step by step, description first. I still think it would be good to keep track of those changes (are all members fine with that change?) here: #280
Will try working on this from my commandline,Incase I find it challenging,I will cry out loud for guidance.
@chardso also ok if you want to change it back a bit later, as it is not lost, all tracked in the Git History ;)
@chardso also ok if you want to change it back a bit later, as it is not lost, all tracked in the Git History ;)
I'll merge it now, we can always add improvements/older part back again later from History @chardso
This is an update of all the profiles of already existing experts, the edit was requested by @romeoplat , I would have used the content branch to make the edits but it contains other profiles that are new and need a lot of work. I went with the main branch because the profile are the approved ones