search

ASML-Labs / PPTX.jl

Generate PowerPoint PPTX files from Julia
https://asml-labs.github.io/PPTX.jl/
MIT License
90 stars 7 forks source link

Refer to "[Content_Types].xml" without ".." #43

Closed jaakkor2 closed 1 year ago

jaakkor2 commented 1 year ago

PPTX.jl v0.6.4 showed permission denied error https://github.com/ASML-Labs/PPTX.jl/pull/42#issuecomment-1682224945 .

I could reproduce that with released v0.6.4, but not with ]dev-ed version. This PR is to remove .. from the path and build the path using variables.

I upped the version number, because if dev-version works, how to debug.

codecov[bot] commented 1 year ago

Codecov Report

Merging #43 (616e856) into main (5f2e746) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          10       10           
  Lines         520      520           
=======================================
  Hits          492      492           
  Misses         28       28
Files Changed Coverage Δ
src/write.jl 87.60% <100.00%> (ø)
matthijscox-asml commented 1 year ago

okay, let's go with this asap to see if it fixes the problem.

matthijscox-asml commented 1 year ago

Okay, I tried to following before the registration is finished, I installed from the git url itself: ]add https://github.com/ASML-Labs/PPTX.jl.git

Then I get v0.6.5, and I get the following error when writing a .pptx:

ERROR: SystemError: opening file "C:\\Users\\matcox\\AppData\\Local\\Temp\\jl_P7kDYd\\no-slides\\[Content_Types].xml": Permission denied
matthijscox-asml commented 1 year ago

I'm a little baffled, but we need to fix this asap, or revert to v0.6.3

jaakkor2 commented 1 year ago

Let's comment out line https://github.com/ASML-Labs/PPTX.jl/blob/main/src/write.jl#L186