search

ASPLes / nopoll

OpenSource WebSocket toolkit
http://www.aspl.es/nopoll
GNU Lesser General Public License v2.1
126 stars 73 forks source link

Check ENOTCONN on SSL_connect error #19

Closed jcelaya closed 7 years ago

jcelaya commented 7 years ago

This happens on Windows (at least) when the TCP connection is not yet established.

francisbrosnan commented 7 years ago

Hi Javier,

Thanks for reporting and providing a patch!

It's difficult for me to reproduce this bug. I guess it has to do with load and some other conditions only happening on windows (no surprise though). Anyway if you say you found this patch solving an issue you have seen, I'll merge this patch.

Again, thanks for your time and effort, Best Regards,

jcelaya commented 7 years ago

Yes, we found this bug in a quite specific situation (on Windows, over a long delay connection). I understand it is difficult to reproduce.

Thank you too for taking your time reviewing our patches. This was the last one (so far...)