francisbrosnan
commented
7 years ago Hello Florian,
Thanks for taking your time to review and propose this. I have no objections about the change.
I have a doubt. Given we check noPoll in more than 20 distributions from debian lenny i686 to ubuntu xenial amd64 (including centos, and windows xp/7/8, etc), what is the OS where you are getting this clashing error?
Again, thanks for your time, Best Regards,
ffainelli
Hello,
While building with a toolchain I noticed that sys/param.h got automatically included and this resulted in the following build error:
/bin/bash ../libtool --tag=CC --mode=compile mipsel-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DVERSION=\""0.4.4.b349"\" -DPACKAGE_DTD_DIR=\""/usr/share"\" -DPACKAGE_TOP_DIR=\"".."\" -DVERSION=\"0.4.4.b349\" -I/home/florian/dev/openwrt/trunk/staging_dir/target-mipsel-unknown-linux-gnu_glibc/usr/include -I/home/florian/dev/openwrt/trunk/staging_dir/target-mipsel-unknown-linux-gnu_glibc/include -I/home/florian/dev/toolchains/stbgcc-4.8-1.5/usr/include -I/home/florian/dev/toolchains/stbgcc-4.8-1.5/include -fstack-protector-all -Wstack-protector -Os -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -Wno-unused-result -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -MT nopoll_loop.lo -MD -MP -MF .deps/nopoll_loop.Tpo -c -o nopoll_loop.lo nopoll_loop.c OpenWrt-libtool: compile: mipsel-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DVERSION=\"0.4.4.b349\" -DPACKAGE_DTD_DIR=\"/usr/share\" -DPACKAGE_TOP_DIR=\"..\" -DVERSION=\"0.4.4.b349\" -I/home/florian/dev/openwrt/trunk/staging_dir/target-mipsel-unknown-linux-gnu_glibc/usr/include -I/home/florian/dev/openwrt/trunk/staging_dir/target-mipsel-unknown-linux-gnu_glibc/include -I/home/florian/dev/toolchains/stbgcc-4.8-1.5/usr/include -I/home/florian/dev/toolchains/stbgcc-4.8-1.5/include -fstack-protector-all -Wstack-protector -Os -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -Wno-unused-result -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -MT nopoll_loop.lo -MD -MP -MF .deps/nopoll_loop.Tpo -c nopoll_loop.c -fPIC -DPIC -o .libs/nopoll_loop.o nopoll_loop.c: In function 'nopoll_loop_process': nopoll_loop.c:112:73: error: macro "isset" passed 3 arguments, but takes just 2 if (ctx->io_engine->isset(ctx, conn->session, ctx->io_engine->io_object)) { ^ Makefile:478: recipe for target 'nopoll_loop.lo' failed make[5]: *** [nopoll_loop.lo] Error 1
I decided to rename isset to is_set and addto to add_to for consistency, this should not create any functional change.
While doing these changes there was also no .gitignore file, so the git status output was all polluted by build products.