search

ASPLes / nopoll

OpenSource WebSocket toolkit
http://www.aspl.es/nopoll
GNU Lesser General Public License v2.1
124 stars 74 forks source link

openssl 1.1: use EVP_MD_CTX as opaque type #27

Closed camilleoudot closed 7 years ago

camilleoudot commented 7 years ago

openssl 1.1.0 made EVP_MD_CTX opaque, this change is required to have nopoll compile (e.g. on Debian 9 with openssl 1.1.0). Still, -Werror needs to be disabled as some functions are now declared deprecated.

camilleoudot commented 7 years ago

I just read a relevant thread on the mailing list, and I just want to stress that this patch proposal makes sure it does not impact older versions. Generally speaking, for this OpenSSL 1.1.x vs. 1.0.x compatibility issue, I feel like the answer is a combinations of autoconf magic, and using the OPENSSL_VERSION_NUMBER macro, defined in openssl/opensslv.h.

francisbrosnan commented 7 years ago

Hi Camille, I'm almost finished checking this patch against all supported platforms ... so far without any issue (compilation + regression tests pass). I think it's ok... I'll keep you updated, Best Regards,

francisbrosnan commented 7 years ago

Hello Camille, I'm merging this patch since the part that it fixes also works in stretch (including lenny, to jessie, precise, xenial, centos6/5...). I'll push another patch that fixes the rest of issues around TLS flexible method covering regression tests and internal context code (and supporting all official platforms..), Thanks for taking your time to provide this patch, Best Regards,