ASPLes / nopoll

OpenSource WebSocket toolkit
http://www.aspl.es/nopoll
GNU Lesser General Public License v2.1
126 stars 73 forks source link

Fix a memory leak when nopoll_conn_close_ext() is called, make sure t… #6

Closed manderiasian closed 8 years ago

manderiasian commented 8 years ago

…o unreference all references.

francisbrosnan commented 8 years ago

Hello, Thanks for reporting. Proposed patch do not passes regression tests (segaults):

cd test/ ./nopoll-regression-listener libtool --mode=execute valgrind --leak-check=yes --error-limit=no ./nopoll-regression-client

You claim this patch fixes a memory leak. However, current regression tests passes with no memory violation and no memory leak (valgrind checked).

Best Regards,

manderiasian commented 8 years ago

Thank you for your response. I will revert the change, as I was suspicious of our code possibly not using the APIs as intended.