search

ASPP / pelita

Actor-based Toolkit for Interactive Language Education in Python
https://github.com/ASPP/pelita_template
Other
62 stars 68 forks source link

make the cumulative time counter available to clients #797

Closed otizonaizit closed 2 months ago

otizonaizit commented 3 months ago

The Bot object should have an attribute time where the cumulative time for the team shown in the GUI is made available. This is useful for example when benchmarking different strategies. There's no way at the moment to programmatically access that value, as far as I could see. Of course the client could time itself, but this has its own pitfalls. So it's better to just make that value available, even if we all know it's not super precise...

Debilski commented 3 months ago

Sure, makes sense. But the cumulative time is not so interesting, no? You’d still have to do calculations and store it somewhere. Personally I would calculate it myself.

otizonaizit commented 3 months ago

Well, if you want to do any statistics you'll need to elaborate a bit, you are right. But if you just want to print it out to quickly check, it's good enough. Given that it is trivial to add and that it is available in the GUI it seems natural to expose the attribute through the bot API. I agree it's not super useful, but it's odd that it's missing from the API.

On Thu 30 May, 08:48 +0000, Rike-Benjamin Schuppner @.***> wrote:

Sure, makes sense. But the cumulative time is not so interesting, no? You’d still have to do calculations and store it somewhere. Personally I would calculate it myself.

— Reply to this email directly, view it on GitHub¹, or unsubscribe². You are receiving this because you authored the thread.☘Message ID: @.***>

––––

¹ https://github.com/ASPP/pelita/issues/797#issuecomment-2140017086 ² https://github.com/notifications/unsubscribe-auth/AACUYCYGNQIWBEECBVSTA53ZE5C5FAVCNFSM6AAAAABIRD3UXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGAYTOMBYGY