search

ASU-CodeDevils / devilbot

A Rust rewrite of Flameboi to work for our Discord Server.
Apache License 2.0
16 stars 1 forks source link

Rhett emoji and events #43

Closed reharri7 closed 1 year ago

reharri7 commented 1 year ago

Referencing and #41 for emoji stuff.

@jtmichelson Can I get a review?

I'd like to refactor the ping command and get rid of the other Slack Crate we were initially using. That might go in this PR it's very smol and quick to do.

reharri7 commented 1 year ago

Also FWIW, those multiple commits above were brought over before I had squashed and merged them. I will squash and merge them again this PR

github-actions[bot] commented 1 year ago

Test Results

0 tests  ±0   0 :heavy_check_mark: ±0   0s :stopwatch: ±0s 1 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit f361e59e. ± Comparison against base commit 179bf2ae.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 year ago

Codecov Report

Merging #43 (f361e59) into main (179bf2a) will decrease coverage by 0.19%. The diff coverage is 1.17%.

@@           Coverage Diff            @@
##            main     #43      +/-   ##
========================================
- Coverage   0.59%   0.39%   -0.20%     
========================================
  Files          9      12       +3     
  Lines        169     251      +82     
========================================
  Hits           1       1              
- Misses       168     250      +82
Impacted Files Coverage Δ
resources/src/commands/buns.rs 0.00% <ø> (ø)
resources/src/commands/conversations_open.rs 0.00% <0.00%> (ø)
resources/src/commands/onboard_user.rs 0.00% <0.00%> (ø)
resources/src/commands/ping.rs 0.00% <0.00%> (ø)
...ources/src/event_handlers/message_event_handler.rs 0.00% <0.00%> (ø)
...src/event_handlers/reaction_added_event_handler.rs 0.00% <0.00%> (ø)
...rces/src/event_handlers/team_join_event_handler.rs 0.00% <0.00%> (ø)
resources/src/slack/add_reaction.rs 0.00% <0.00%> (ø)
resources/src/slack/chat_post_message.rs 0.00% <0.00%> (ø)
resources/src/slack/client.rs 0.00% <0.00%> (ø)
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jtmichelson commented 1 year ago

Referencing and #41 for emoji stuff.

@jtmichelson Can I get a review?

I'd like to refactor the ping command and get rid of the other Slack Crate we were initially using. That might go in this PR it's very smol and quick to do.

If you want to refactor the ping command that's fine since it's similar in structure to how you refactored the emoji command here. Best practices suggest that PRs should be as small as possible and have a very specific intent. If you wanted to migrate to the new Slack crate that should be its own Git Issue and PR.

jtmichelson commented 1 year ago

Referencing and #41 for emoji stuff. @jtmichelson Can I get a review? I'd like to refactor the ping command and get rid of the other Slack Crate we were initially using. That might go in this PR it's very smol and quick to do.

If you want to refactor the ping command that's fine since it's similar in structure to how you refactored the emoji command here. Best practices suggest that PRs should be as small as possible and have a very specific intent. If you wanted to migrate to the new Slack crate that should be its own Git Issue and PR.

Oh, I see. You've decided to use reqwest and JSON payloads for everything instead of a Slack client. This is fine, but it's probably not the cleanest way to go about things.