search

ASU-CompMethodsPhysics-PHY494 / final-2018-fourier-transforms

final-2018-fourier-transforms created by GitHub Classroom
0 stars 0 forks source link

review proposal #1

Closed orbeckst closed 6 years ago

orbeckst commented 6 years ago

I will review the proposal.

@ASU-CompMethodsPhysics-PHY494/fourier-transforms Please leave a comment here once you addressed my comments.

Note that the proposal should have the names of all team members on it. There should be 2–4 specific objectives with measurable outcomes. It should be about 1 page but it can be longer if necessary.

The Proposal should guide your overall directions of the project and form the basis of your decisions of what to work on.

orbeckst commented 6 years ago

Please address the following points

  1. include sections Problem (state what the general question is), Approach (how you are addressing the question), Objectives. You could introduce your 4 test systems in Approach and then in Objectives say:
    1. analytically solve systems (1) - (4) to get momentum space wavefunction
    2. use numpy's DFT to ...
    3. ....
    4. Stretch Goal: ...
  2. clearly number your objectives (see above – the roman numeral numbering is automatically generated, I would use standard arabic numerals in the proposal)

Minor comments

Once you have addressed the points, please leave a comment here and ask to re-review.

orbeckst commented 6 years ago

@ASU-CompMethodsPhysics-PHY494/fourier-transforms please spend a few minutes on finalizing your proposal.

jonahshoe commented 6 years ago

Hey Professor,

Finishing it up now! Sorry about the wait.

On Thu, Apr 19, 2018 at 11:49 PM, Oliver Beckstein <notifications@github.com

wrote:

@ASU-CompMethodsPhysics-PHY494/fourier-transforms https://github.com/orgs/ASU-CompMethodsPhysics-PHY494/teams/fourier-transforms please spend a few minutes on finalizing your proposal.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/ASU-CompMethodsPhysics-PHY494/final-2018-fourier-transforms/issues/1#issuecomment-382997934, or mute the thread https://github.com/notifications/unsubscribe-auth/AiYYfq52oFFQXj-DMEiT9nl6J01Wqt4yks5tqYTlgaJpZM4Taczh .

jonahshoe commented 6 years ago

Updated the proposal, review when convenient!

orbeckst commented 6 years ago

Thanks, looking good.

I approve the proposal. Please get started.