ASU-KE / UDS-WordPress-Theme

WordPress theme styled using the ASU Unity Design System (@asu/unity-bootstrap-theme 2023)
GNU General Public License v2.0
1 stars 1 forks source link

2024 theme update #448

Closed jkcox closed 2 weeks ago

jkcox commented 2 months ago
zainabD commented 1 month ago

Is this ready for review?

zainabD commented 4 weeks ago

I tested this on Biodesign QA website:

For example in the home page, under Spotlight: 20th Anniversary section:

Screenshot 2024-09-05 at 10 13 47 AM
zainabD commented 4 weeks ago
zainabD commented 4 weeks ago
zainabD commented 3 weeks ago
jkcox commented 3 weeks ago
  • [x] Replacing the uds-section-gradient class with one of the overlay classes should fix the gradient issue. I have already replaced it on the E+I site, but let's make sure it's not being used on other websites before we can merge this branch in.
  • [x] @jkcox The ASU logo and mobile menu disappear when logged in to the WP admin. See examples on Biodesign QA and E+I QA:

Ok I see what happed now - position:sticky was added because there is a gap between the main menu and top of window when scrolling where the admin bar would be located.

But for some reason at the top it is not sticky to top of window - should be able to find a solution.