ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
13 stars 8 forks source link

fix(unity-bootstrap-theme): update blockquote image size in breakpoint #1082

Closed mlsamuelson closed 1 year ago

mlsamuelson commented 1 year ago

NOT TO BE MERGED UNTIL ORIGINAL WS2 FIX IS CONFIRMED.

Description

With blockquote images, on different breakpoints the image will skew, then disappear, then reappear set to the left in some use cases.

Solution: Adjusting images styles in the blockquote component for different resolutions.

(Note, this PR is derived from https://github.com/ASUWebPlatforms/webspark-ci/pull/53 doesn't regress and to address this edge case)

Links

davidornelas11 commented 1 year ago

Should this be tested in an updated ws2 environment as well once we have that ready?

mlsamuelson commented 1 year ago

This is a backport (forwardport?) of a fix that was made in WS2 to the BS4 theme for the 2.10.0 WS2 release. It tested out there. With the next WS2 release we'll be adopting the BS5 theme and giving everything the once-over, so it will get validated there.