ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

fix(unity-bootstrap-theme): card horizontal fixed height and aspect r… #1129

Closed davidornelas11 closed 1 year ago

davidornelas11 commented 1 year ago

…atio

Description

Horizontal cards need to have a correct aspect ratio and fixed max-height. Card arrangements also needed to be added as a story to show horizontal cards in the card arrangements

Links

Checklist

Browsers

mlsamuelson commented 1 year ago

@davidornelas11 Looks like the mobile stacking happens with how these are implemented in WS2 (see https://dev-webspark-ci.ws.asu.edu/card-arrangement). So, would be nice if that showed in Storybook. Maybe not a requirement if it's a challenge.

davidornelas11 commented 1 year ago

Not a challenge.; I can add that stacking

davidornelas11 commented 1 year ago

@davidornelas11 Looks like the mobile stacking happens with how these are implemented in WS2 (see https://dev-webspark-ci.ws.asu.edu/card-arrangement). So, would be nice if that showed in Storybook. Maybe not a requirement if it's a challenge.

So this most recent change i pushed up involves wrapping the horizontal cards in the card arrangement, as adding more templates using the templates control just adds another component outside the html-root wrapper, so it can not be altered from within the component. If my recent code is too messy, I suggest not having them stack since it is not a card arrangement

mlsamuelson commented 1 year ago

I've approved. Can't be merged until @scott-williams-az also approves since he had requested changes. From what I see, those changes were made.