fix(components-core): improve pagination accessibility, remove unused… - Githubissues

ASU / asu-unity-stack

ASU Unity Design System

https://unity.web.asu.edu/

Other

11 stars 8 forks source link

fix(components-core): improve pagination accessibility, remove unused… #1145

Closed davidornelas11 closed 1 year ago

davidornelas11 commented 1 year ago

… props

Added accessibility in pagination component and removed unused props

BREAKING CHANGE: Removed unused props

Description

Fixed accessibility in pagination component and remove unused props

Links

Checklist

[x] Unity project successfully builds from root yarn install & yarn build
[x] Commits do not contain multiple scopes
[x] Add/updated examples
[x] Add/updated READMEs/docs
[x] No new console errors
[x] Accessibility checks

Browsers

[x] Chrome
[x] Safari
[x] Firefox
[x] Edge

davidornelas11 commented 1 year ago

@davidornelas11 We need to model these changes as best as possible (it doesn't need to be interactive) in unity-bootstrap-theme too, so we keep that reference in sync.

So my thinking on this is that most of these changes need Javascript to take effect, so i can hard code some of the things like aria-label and aria-current, but we would need to make it known that if someone utilizes this in the bootstrap-theme form and not components-core, they need to make sure they have javascript taking care of this