UDS-1467: fix(header): fix accessibility bug in header

[daemon-node-byte]

Description

Problem Detected a bug during the accessibility page scan on the Undergrad Admissions App

Extra: large empty space in mobile nav link dropdown

Container element is empty Some roles are designed to contain other roles. This element has this type of role, but it doesn't contain any required-owned elements.

Solution Prevent the empty element from writing to the DOM.

Extra: removed min-height property from element

Links

• Issue Tracker #1149

• JIRA ticket UDS-1467

• JIRA ticket UAA-449

• ASU Admissions

• Unity Design Kit

• Unity reference site

Checklist

• [x] Unity project successfully builds from root yarn install & yarn build
• [x] Commits do not contain multiple scopes
• [x] Add/updated examples
• [x] Add/updated READMEs/docs
• [x] No new console errors
• [x] Accessibility checks

Browsers

• [x] Chrome
• [x] Safari
• [x] Firefox
• [x] Edge

Images

Before removing min-height

After removing min-height

With nav links and removed min-height

[scott-williams-az]

Dave is correct, I was looking at the specs and the docs assume the open menu take over the screen. https://xd.adobe.com/view/56f6cb78-9af5-4b12-b4ce-ef319f71113f-03a5/screen/02335e90-65c1-4245-8fc7-71b70322c4ff/

Edited: Oops I missed the no Nav example, I think this should be OK (Sorry for the back and forth)

[daemon-node-byte]

Thank you @scott-williams-az and @davidornelas11 for review and approvals.