ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
13 stars 8 forks source link

fix(unity-bootstrap-theme): nested containers failsafe, include conta… #1153

Closed scott-williams-az closed 1 year ago

scott-williams-az commented 1 year ago

nested containers failsafe, include container end styles only once

Description

button issue on mobile was caused by nested container padding https://chs.asu.edu/bachelors-degrees/majorinfo/ECEXERBS/undergrad/false/91407

Links

Checklist

Browsers

Images

image

image

mlsamuelson commented 1 year ago

@scott-williams-az I believe we decided this isn't advisable as the solution to this issue due to there being valid instances where nested containers are used in WS2. Right? Thoughts on an alternate approach?

scott-williams-az commented 1 year ago

There are valid use cases for nested containers, however the nested container should have a parent with the row class. The solution should not be solved with css, we should ensure a nested container has a parent row going forward.