ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

fix(component-header):highlight nav parent if subitem active #1230

Closed scott-williams-az closed 8 months ago

scott-williams-az commented 8 months ago

Description

Has anyone noticed on their site that if they have multiple columns in their menu items that anything not in the first column will not highlight the menu navigation when they are on that page?

Links

Checklist

Browsers

Images

image
scott-williams-az commented 8 months ago

This could use some discussion, as I don't necessarily think the additional prop for currentPage is needed

and the change in the first commit actually doesn't do anything (at least for WS2) since we are never setting a sub menu item with selected=true