This is still a work in progress, but I would like a review before I go further
Commits are separated into common changes, and will hopefully make this easier to review.
Notes
Created new shared components folder for layout, I am looking for feedback on this. I'd like to set a common pattern for layout, but this might be better as a storybook decorator.
Storybook was incompatible with the createComponent pattern in unity-bootstrap-theme/helpers/wrapper.js
unity-bootstrap-theme works however removing createComponent removes the html view and not all stories have been hook up again.
All other Storybook packages seem to be working
Removed deprecated knobs and fixed broken controls in components carousel
I made several changes for @asu/packages should match the major version in order for the workspace to use local version in development,
Description
This is still a work in progress, but I would like a review before I go further
Commits are separated into common changes, and will hopefully make this easier to review.
Notes
Created new shared components folder for layout, I am looking for feedback on this. I'd like to set a common pattern for layout, but this might be better as a storybook decorator.
Storybook was incompatible with the createComponent pattern in
unity-bootstrap-theme/helpers/wrapper.jsunity-bootstrap-theme works however removing createComponent removes the html view and not all stories have been hook up again.
All other Storybook packages seem to be working
Removed deprecated knobs and fixed broken controls in components carousel
I made several changes for
@asu/packagesshould match the major version in order for the workspace to use local version in development,"@asu/components-core": "^3.0.0","@asu/unity-bootstrap-theme": "^1.0.0",we should limit to a major versionLinks