search

ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

fix(unity-bootstrap-theme): fix style leak for buttons #1258

Closed tbutterf closed 6 months ago

tbutterf commented 6 months ago

UDS-1630

Description

There is a style leak on _misc that causes anchor buttons to have maroon text. The _misc.scss file has a rule that says:

.bg-light a,
.bg-secondary a,
.bg-white a {
  color: $primary;
}

This causes a problem with buttons when they are placed on content that uses the “bg-white” style.

The solution is to limit the rule to everything but buttons, which is what is done elsewhere in bootstrap.

.bg-light a:not(.btn),
.bg-secondary a:not(.btn),
.bg-white a:not(.btn) {
  color: $primary;
}

This blocks WS2-1656, so it would be good if it could get merged before that ticket's PR.

Links

FOR APPROVERS

Checklist

Browsers