ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

fix(component-header): added default GTM info to link clicks #1299

Closed davidornelas11 closed 3 months ago

davidornelas11 commented 3 months ago

Description

added default GTM info to link clicks

Links

FOR APPROVERS

Checklist

Browsers

Images

davidornelas11 commented 3 months ago

I think we're on track with this. I noticed in the CFO site, there's a region value that's not being set in the fix yet, and the fix includes a component value that's not set (and also not in the CFO site). That component value - was that one we're setting as part of the global variable update for tracking components in the GTM? I didn't think we'd be touching the dataLayer with that... And maybe it's not that.

The other thing I noticed is that there aren't a full set of values being sent in for the collapse event clicks on the menu for the drop downs like there are on the pre-regressed CFO site.

So I think we still need to address those two items:

  • region and maybe component
  • collapse event clicks need full event details too.

From what I understand, the component value was set a few years ago and from what I found, it was never really used but I think adding that in the shared function might be better. Never mind, it is set in the shared function so that’s still there. The region was hardcoded as well so that will need to be hard coded again