Hero H1 A11y issue - Githubissues

ASU / asu-unity-stack

ASU Unity Design System

https://unity.web.asu.edu/

Other

11 stars 8 forks source link

Hero H1 A11y issue #1326

Closed scott-williams-az closed 1 month ago

scott-williams-az commented 2 months ago

Description

This ticket has 3 items, This PR address item 1 The doc-subtitle role is exposed as a heading with no level

The doc-subtitle role is meant for document, it is not meant for web

hgroup was being deprecated, however it may have made a come back as I still see relevant documentation:

https://html.spec.whatwg.org/multipage/sections.html#the-hgroup-element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hgroup There is another option to use header which does have an example of text before the h1
https://html.spec.whatwg.org/multipage/sections.html#the-header-element

Links

FOR APPROVERS

Percy build approval

scott-williams-az commented 1 month ago

I thought about making it a breaking change, but because the code is still backwards compatible So that is why I did not, but I can make that commit.

mlsamuelson commented 1 month ago

All good if it's backwards compatible. :) Thanks, @scott-williams-az .