search

ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

UDS-1756: feat(unity-bootstrap-theme): modified _banner.scss, banners.templates.stories.js for accessibility #1330

Closed juanmitriatti closed 1 month ago

juanmitriatti commented 2 months ago

feat(unity-bootstrap-theme): modified _banner.scss, banners.templates.stories.js for accessibility

UDS-1756

Description

Links

FOR APPROVERS

scott-williams-az commented 2 months ago

@mlsamuelson I am concerned with changing the banner to H1. Banner is already wrapped in a section which is good. We want to make sure the page structure (with different section, article, aside, etc) is correct to allow 2 H1's.

I found this, however the detail in this section still left me with questions. https://www.w3.org/WAI/tutorials/page-structure/headings/#main-heading-after-navigation

juanmitriatti commented 2 months ago

@mlsamuelson I am concerned with changing the banner to H1. Banner is already wrapped in a section which is good. We want to make sure the page structure (with different section, article, aside, etc) is correct to allow 2 H1's.

I found this, however the detail in this section still left me with questions. https://www.w3.org/WAI/tutorials/page-structure/headings/#main-heading-after-navigation

Hi @scott-williams-az , @mlsamuelson The reason for changing the banner to an H1 is to meet an accessibility requirement mentioned in this ticket: https://asudev.jira.com/browse/WS2-2194.

Thanks!

mlsamuelson commented 2 months ago

Let's confirm with Kathy.

mlsamuelson commented 2 months ago

We need to hold on this until we have clarity from Kathy. See the conversation at https://asu-tech.slack.com/archives/CT01Z74KY/p1722018704187699

scott-williams-az commented 1 month ago

Looks good