search

ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

Uds 1685: Add keyboard navigation to header #1332

Closed davidornelas11 closed 1 month ago

davidornelas11 commented 1 month ago

Description

Added full keyboard navigation with header dropdown menus.

For testing:

  1. Dropdown menus should be navigable with the keyboard arrows as well as tab
  2. When inside a dropdown menu, the esc key should close the menu and put the focus at the parent link
  3. Voiceover should recognize if the menu is expanded or not

Links

FOR APPROVERS

davidornelas11 commented 1 month ago

Couple questions, @davidornelas11.

Because it's used for more than focusing the next link, what do you think about renaming focusOnNextLink() to handleLinkFocus() or something similar, to better reflect what that function does?

Do we need to implement similar updates for the Bootstrap version of the header?

i agree on renaming the function. As far as the unity-bootstrap-theme, we would need to include the custom js file in the storybook with some instructions but it would just be for people who implement that instead of the react header.