search

ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
11 stars 8 forks source link

fix(unity-bootstrap-theme): added css for long pagination on mobile #1337

Closed juanmitriatti closed 3 weeks ago

juanmitriatti commented 1 month ago

UDS-1754

Description

Solution

Added css for long pagination on mobile

Links

FOR APPROVERS

scott-williams-az commented 1 month ago

I was just looking at this, I am curious if we have our padding correct for the container class on mobile. 2rem seems high as the padding is .75rem on larger breakpoints. Sort of related to this ticket since the padding squeezes all the content. But this could be a separate ticket if the breakpoint padding needs adjusting

juanmitriatti commented 1 month ago

I was just looking at this, I am curious if we have our padding correct for the container class on mobile. 2rem seems high as the padding is .75rem on larger breakpoints. Sort of related to this ticket since the padding squeezes all the content. But this could be a separate ticket if the breakpoint padding needs adjusting

I added 'gap: 0' so that the pages don't get lost, in addition to the 'paddings' to center them. I would consult with @mlsamuelson about whether to modify the 'container' in this ticket or create a new ticket, as I think it would be good to make the suggested change.

mlsamuelson commented 1 month ago

@juanmitriatti I spoke with @scott-williams-az about this in standup the other day. The plan from that conversation was that he was going to create a separate ticket for the container padding issue. It does not need to be addressed in this PR.