search

ASU / asu-unity-stack

ASU Unity Design System
https://unity.web.asu.edu/
Other
13 stars 8 forks source link

fix(app-webdir-ui): prevent SearchResultsList from fetching titles when there are no results #1366

Closed davidornelas11 closed 1 month ago

davidornelas11 commented 1 month ago

prevent SearchResultsList from fetching titles when there are no results

Also added early return for any webdirectory that has the method of POST, since these already have the title info

FOR APPROVERS

Screen Shot 2024-09-20 at 11 59 41 AM

davidornelas11 commented 1 month ago

Looks good. We do not have any coverage for if the API take too long or fails. Can we create a ticket for that, it might be too much to ask to include with this PR

Agree on creating a ticket for this. It should encompass all the fetch requests so it may be a bit bigger than this ticket