search

ASWWU-Web / python_server

The API server for ASWWU Web. This project uses the Tornado web framework to serve and manage data across all ASWWU sites.
https://aswwu.com/server
4 stars 10 forks source link

mask.py reports success on failure #124

Closed dakriy closed 4 months ago

dakriy commented 5 years ago

route_handlers/mask.py on line 256 does not check the return of mask.add_or_update(profile) and will always return success. The function returns None on failure, and should be checked instead of always assuming it worked and returning success when it obviously didn't succeed.

ermsdev commented 4 years ago

Thanks @dakriy, this is probably something we won't plan on fixing since it's not a security vulnerability, it doesn't appear to be breaking anything at the moment (let us know if you see something it is causing to break), and we're in the process of migrating to Django.

If you think it's a simple fix you're welcome to open a PR from a fork with a change. I may get a chance to look into it but it won't be a high priority for the time being.

I'm adding it to the Django Migration project board so we make sure to keep it in mind as we design the new server backend.