WIP: New Notification System

[stacmi]

This is a WIP - Do Not Merge - this code is not in working condition yet

purpose

This pull request is for collaboration on the new system which is not yet finished

notes

new endpoints for notifications consistiong of

• POST
• PATCH
• GET

Currently there is only skeleton code for POST which still needs a lot of work

[ermsdev]

A few of thoughts for this:

• take a look at other endpoints to see how post and get requests are handled. Typically one endpoint is used for interacting with one resource, the difference between GET and POST is in in the headers of a request rather than the URL.
• a good way to get started is to clean out the methods for post and get that are associated with your new endpoint and try to get them to just return something like a 'helloworld' to the client. the self.status and self.write methods are used for sending a response to the client.
• once you get a successful response we can focus on interacting with the database and securing the endpoint.

[stacmi]

moved the notifications code into homepage and then started creating the notifications db

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 33.12883% with 109 lines in your changes missing coverage. Please review.

Project coverage is 47.57%. Comparing base (4c93cec) to head (b848b7b). Report is 77 commits behind head on develop.

Files	Patch %	Lines
src/aswwu/route_handlers/homepage.py	22.95%	47 Missing :warning:
src/aswwu/alchemy_new/notifications.py	34.09%	29 Missing :warning:
src/aswwu/validators/notifications.py	23.07%	20 Missing :warning:
src/aswwu/models/bases.py	36.84%	12 Missing :warning:
src/aswwu/models/notifications.py	91.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #162 +/- ## =========================================== - Coverage 48.35% 47.57% -0.78% =========================================== Files 29 32 +3 Lines 3032 3195 +163 =========================================== + Hits 1466 1520 +54 - Misses 1566 1675 +109 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[stacmi]

@stephenermshar

There is an issue setting the current user of the session. Issue appears when adding the decorator @tornado.web.authenticated where the issue of current_user has no attribute username come up. Need to look into it more as currently using postman requests to test the new changes.

Core functionality works. Working on adding authentication and validators.

[ermsdev]

what's in your settings.py file?

[stacmi]

keys = {
    'hmac':"fakekeystring",
    'samlEndpointKey': "fakekeystring"
}
testing = {
    'pytest': False,  # enables access to roles endpoint, set to false in production
    'dev': True,  # bypasses authentication and logs in `developer`
    'developer': 2024971,
    'base_url': 'http://127.0.0.1',
    'port': 8888,
    'log_name': 'aswwu_test',
    'current_year': '1920',
    'database': './testing_databases',
}
production = {
    'port': 8888,
    'log_name': 'aswwu',
    'current_year': '1920',
}
email = {
    'username': 'aswwu.webmaster@wallawalla.edu',
    'password': 'fakepassword'
}
database = {
    'location': './testing_databases'
}

[ermsdev]

This could be related to the database['location'] variable being set to './testing_databases' rather than your actual local database. the poeople.db in './testing_databases' should not contain your wwuid since it's intended for automated pytests, not running the server locally. There's a new settings.py file I'm working on that should address that issue. Until then, make sure you have a copy of the full database in a folder on the same level as your python repository, and set

database = {
    'location': '../databases'
}

[stacmi]

Code is up to date.

Core functionality tested and working using postman requests.

secured the endpoint for post/put requests.

[ermsdev]

quick reminders from today's meeting:

• [ ] make sure you make the notification_links column name singular.
• [ ] add validation to the visible column
• [ ] add a boolean archived column

If sqlite/sqlalchemy supports boolean types for columns we should use a boolean value for visible and archived instead of an integer.

[ermsdev]

To make sure this project is in a good state when the school year ends, I think it would be good to prepare it for deployment and have it running on the live server early this week. Until the frontend administration components are finished we'll have to add and remove notifications with SQL through SSH, which is still an improvement over redeploying the frontend site with html notifications.

this week make sure:

• [ ] you know how to migrate the database to the new schema, and
• [x] the API can return a list of all notifications stored in the table.