search

AScustomWorks / AS

VCV Rack Modules
Other
114 stars 16 forks source link

Potential dropouts due to VU meteres #15

Closed aebrouse closed 6 years ago

aebrouse commented 6 years ago

Hey Alfredo,
YEs , the problems I had had been having with Rack seems to stem from your VU meters.. Attached are both the patch that gave issues and the same patch without your meters.

06trialrack.zip

I am sure you followed my posts in group.. oh and your tiny OSC's .. They flicker randomly not in any relation to frequency generated.

AScustomWorks commented 6 years ago

Is this patch making the audio glitches? Tried it (without Bidoo module, I can't install it yet) and everything else appeared to be working fine even when setting the block size to 64 so I can't reproduce the error.

Try making a new patch from zero (so you can discard patch weirdness), and narrowing it down to the least amount of modules needed to reproduce the glitches, using only AS modules would be even better for the sake of testing.

"Also, maybe not that relevant as it seems to be working, but the VU meters are not meant to read -V, and the signal is not clamped, otherwise you couldn't monitor saturated signal levels. It may be worth checking that routing on your LFOs. If anything, the VU meters are only showing you the positive half of the signal." <- IGNORE this, actually I made a test with an atenuverter going to both VU meters, it registers just fine both - and + volt values.

AScustomWorks commented 6 years ago

Now, on the code side this is all what's happening with the VU meters:

    //GET VALUES AND ROUTE SIGNALS TO OUTPUTS
    float signal_in_Left = inputs[INPUT_LEFT].value;
    float signal_in_Right = inputs[INPUT_RIGHT].value;
    outputs[OUT_LEFT].value = signal_in_Left;
    outputs[OUT_RIGHT].value = signal_in_Right;
    //VU METER BARS LIGHTS
    vuBar.dBInterval = 3;
    for (int i = 0; i < 15; i++){
        vuBar.setValue(signal_in_Left / 10.0f);
        lights[METER_LIGHT_LEFT + i].setBrightnessSmooth(vuBar.getBrightness(i));
        vuBar.setValue(signal_in_Right / 10.0f);
        lights[METER_LIGHT_RIGHT + i].setBrightnessSmooth(vuBar.getBrightness(i));
    }

Can't see how this code would make audio glitches compared to what any complex (vcos for example)module is doing internally.

I could test your original patch now with Bidoo module too, everything still fine. I'll wait for a simpler patch with the error ;)

aebrouse commented 6 years ago

Freddy, I can put together a simple patch to see if I can reproduce the error .. all I know is that I only get this problem with the vu meters running .. i'll get back to you soonest. Yes , I figured the code would be uber-simple . worse-to-worst Ill just have to patch without your oh so pretty meters 😊

From: Freddy notifications@github.com Sent: Sunday, April 1, 2018 1:28 PM To: AScustomWorks/AS Cc: aebrouse; Author Subject: Re: [AScustomWorks/AS] Potential dropouts due to VU meteres (#15)

Now, on the code side this is all what's happening with the VU meters:

    //GET VALUES AND ROUTE SIGNALS TO OUTPUTS
    float signal_in_Left = inputs[INPUT_LEFT].value;
    float signal_in_Right = inputs[INPUT_RIGHT].value;
    outputs[OUT_LEFT].value = signal_in_Left;
    outputs[OUT_RIGHT].value = signal_in_Right;
    //VU METER BARS LIGHTS
    vuBar.dBInterval = 3;
    for (int i = 0; i < 15; i++){
            vuBar.setValue(signal_in_Left / 10.0f);
            lights[METER_LIGHT_LEFT + i].setBrightnessSmooth(vuBar.getBrightness(i));
            vuBar.setValue(signal_in_Right / 10.0f);
            lights[METER_LIGHT_RIGHT + i].setBrightnessSmooth(vuBar.getBrightness(i));
    }

Can't see how this code would make audio glitches compared to what any complex (vcos for example)module is doing internally.

I could test your original patch now with Bidoo module too, everything still fine. I'll wait for a simpler patch with the error ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AScustomWorks/AS/issues/15#issuecomment-377802597, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkNbgFUk3mp18W5603jektae_tKG0I7Zks5tkQ5RgaJpZM4TCr8G.

aebrouse commented 6 years ago

Um it seems that the error does not occur unless I have 2 or more vu meters running at same time I normally run 4 or 8 stereo meters... at this moment I am running a nearly simple patch with just one stereo vu meter monitoring output to interface and no problem. I'll experiment some more to reproduce error.

From: Freddy notifications@github.com Sent: Sunday, April 1, 2018 1:28 PM To: AScustomWorks/AS Cc: aebrouse; Author Subject: Re: [AScustomWorks/AS] Potential dropouts due to VU meteres (#15)

Now, on the code side this is all what's happening with the VU meters:

    //GET VALUES AND ROUTE SIGNALS TO OUTPUTS
    float signal_in_Left = inputs[INPUT_LEFT].value;
    float signal_in_Right = inputs[INPUT_RIGHT].value;
    outputs[OUT_LEFT].value = signal_in_Left;
    outputs[OUT_RIGHT].value = signal_in_Right;
    //VU METER BARS LIGHTS
    vuBar.dBInterval = 3;
    for (int i = 0; i < 15; i++){
            vuBar.setValue(signal_in_Left / 10.0f);
            lights[METER_LIGHT_LEFT + i].setBrightnessSmooth(vuBar.getBrightness(i));
            vuBar.setValue(signal_in_Right / 10.0f);
            lights[METER_LIGHT_RIGHT + i].setBrightnessSmooth(vuBar.getBrightness(i));
    }

Can't see how this code would make audio glitches compared to what any complex (vcos for example)module is doing internally.

I could test your original patch now with Bidoo module too, everything still fine. I'll wait for a simpler patch with the error ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AScustomWorks/AS/issues/15#issuecomment-377802597, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkNbgFUk3mp18W5603jektae_tKG0I7Zks5tkQ5RgaJpZM4TCr8G.

AScustomWorks commented 6 years ago

closing this one, follow up here