AScustomWorks / AS

VCV Rack Modules
Other
114 stars 16 forks source link

[Feature Request] - Add Accent input to VCA #48

Open mikeloveridge opened 5 years ago

mikeloveridge commented 5 years ago

What would be nice is if a VCA had an Accent input as well as the normal CV from an envelope generator. It could have a CV knob that lets you choose the amount of accent when it arrives. It seems that summing the EG CV input with the Accent input is all that's needed. Of course, it may not be that simple. Thanks for considering. I tend to use the Fundamental VCA most frequently since it's very simple in appearance and function and has graphical feedback. I use yours when I need stereo VCAs. I use your ADSR almost exclusively and Bogaudio on occasion. Mike

AScustomWorks commented 5 years ago

Thanks Mike, is it possible to recreate the exact behavior you are looking for, using some modules together? If so, an example patch would be great, to see exactly what you want. Let's see if I understand:

mikeloveridge commented 5 years ago

Hi!,

I'll put a patch together for sure! I should be able to get to this today.

Thanks!

On Mon, Jul 22, 2019 at 7:53 PM Freddy notifications@github.com wrote:

Thanks Mike, is it possible to recreate the exact behavior you are looking for, using some modules together? If so, an example patch would be great, to see exactly what you want. Let's see if I understand:

  • We need an extra input port, for the accent signal
  • Accent signal (gate) present would sum it's designed % to the gain fader, right? (extra knob needed to set the %, basically is just an attenuator)
  • The accent signal would keep the gain raised as long as the signal is present.
  • What happens if the envelope signal finishes before the accent signal?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AScustomWorks/AS/issues/48?email_source=notifications&email_token=ADSEGNAHKR6UDCNEQMELHYLQAZXBZA5CNFSM4IF6ZQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2RYJ5Q#issuecomment-514032886, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSEGNG632CSC2VJHBA2L2DQAZXBZANCNFSM4IF6ZQ7A .

mikeloveridge commented 5 years ago

Hi,

Made an attempt to be fancy with this demo. See the attachments.

I think what would need to happen is the Accent input would affect the amplitude of the attack only. The CV knob would adjust how much amplitude the accent would have. This scenario only allows for a set accent amount.

Another scenario would be seen in Accent2.vcv where the accent is a cv and not just a gate or trigger. In this case, I'm using a separate line in the sequencer to create the accents. This creates a much nicer accent, but is very convoluted.

To create the second scenario with a single module, there would need to be an Accent input on a VCA that was not a gate but an amplitude mod of the attack phase. The decay would come down from there.

Hope this makes sense. And! Maybe there is a better way that others use that I'm not aware of. What I like about this way is I can adjust the accent on any note and make it slightly different making it sound more natural.

Thanks! Mike

On Mon, Jul 22, 2019 at 7:53 PM Freddy notifications@github.com wrote:

Thanks Mike, is it possible to recreate the exact behavior you are looking for, using some modules together? If so, an example patch would be great, to see exactly what you want. Let's see if I understand:

  • We need an extra input port, for the accent signal
  • Accent signal (gate) present would sum it's designed % to the gain fader, right? (extra knob needed to set the %, basically is just an attenuator)
  • The accent signal would keep the gain raised as long as the signal is present.
  • What happens if the envelope signal finishes before the accent signal?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AScustomWorks/AS/issues/48?email_source=notifications&email_token=ADSEGNAHKR6UDCNEQMELHYLQAZXBZA5CNFSM4IF6ZQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2RYJ5Q#issuecomment-514032886, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSEGNG632CSC2VJHBA2L2DQAZXBZANCNFSM4IF6ZQ7A .

AScustomWorks commented 5 years ago

Hi Mike, can't see the attachments. can you try again?

mikeloveridge commented 5 years ago

Hopefully they show up this time. Sorry for the delay.

Mike

On Thu, Jul 25, 2019 at 7:32 PM Freddy notifications@github.com wrote:

Hi Mike, can't see the attachments. can you try again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AScustomWorks/AS/issues/48?email_source=notifications&email_token=ADSEGNBJWYJFQS72YFD7B5TQBJO4XA5CNFSM4IF6ZQ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23KAXA#issuecomment-515285084, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSEGNDYXIABE2KTZS7X2J3QBJO4XANCNFSM4IF6ZQ7A .

mikeloveridge commented 5 years ago

Let me try also through github. Accent2 Accents

mikeloveridge commented 5 years ago

It seems I can only paste images here and not patches.