Closed russelljjarvis closed 1 year ago
Since Julia 1.6 is almost out and will probably become the next LTS, I'm willing to ignore the 1.0 CI failure.
AOK sounds reasonable.
One thing I'd like @AStupidBear to comment on is the special-casing of spike_raster
in src/main.jl
. It might warrant having a setup_simulation
/teardown_simulation
call before and after simulation occurs, respectively, to setup and clean-up these sorts of variables.
@russelljjarvis would you be able to implement setup_simulation
/teardown_simulation
in src/main.jl
? They would be called with all the same arguments as sim!
, and would then call setup_model
/teardown_model
on each model in P
and C
, with dt
and duration
passed as arguments. Then each model can choose to implement setup_model
/teardown_model
to do what they need, or else we'll just have a fallback method that does nothing.
Cleaner pull request of AdExp model + appropriate testing files and constructor entry.