AT-UI / at-ui-style

MIT License
96 stars 32 forks source link

Override doesn't work #16

Open Michael-Reich opened 6 years ago

Michael-Reich commented 6 years ago

I use the standard template from nuxt-starter and try to import scss to override variables. But it does not work:

@import '../node_modules/at-ui-style/src/variables/default.scss';
@import '../node_modules/at-ui-style/src/variables/timing-function.scss';

$link-color: #c03;
$btn-primary-bg: #c03;

@import '../node_modules/at-ui-style/src/mixins/index.scss';
@import '../node_modules/at-ui-style/src/core/index.scss';
@import '../node_modules/at-ui-style/src/components/index.scss';

Embeded in the Layout.vue

<template>
  <div>
    <Header/>
    <nuxt/>
  </div>
</template>

<script>
  import Vue from 'vue'
  import AtComponents from 'at-ui'
  import Header from '~/components/Header.vue'

  Vue.use(AtComponents)

  export default {
    components: {
      Header
    }
  }
</script>

<style lang="scss">
 @import '../assets/main.scss';

  img {
    image-rendering: auto;
    image-rendering: crisp-edges;
  }
</style>
bryanculver commented 6 years ago

I ran into the same issue. Filing a pull request to handle this.

Michael-Reich commented 6 years ago

Thank you, did you already got accepted?

yoyo837 commented 6 years ago

The maintainer was a bit busy recently. So...

bryanculver commented 6 years ago

@Michael-Reich Unfortunately it's still open: https://github.com/AT-UI/at-ui-style/pull/18

shredding commented 6 years ago

How can we push this? The package is super awesome with this fix applied and basically useless without it.

bryanculver commented 6 years ago

@shredding Unfortunately we would need a maintainer, which appears to be @koppthe or @JChehe, to merge this in and they seem back up currently. There has been no response to this ticket or pull request.

shredding commented 6 years ago

There has been no response

At least they maintain the same spirit as in their mobile phone contract support.

Just kidding :-)

bryanculver commented 6 years ago

At least they maintain the same spirit as in their mobile phone contract support.

Thankfully this isn't associated with AT&T. 😆