search

ATFutures / calendar

R interface to iCal (.ics files)
https://atfutures.github.io/calendar/
Other
38 stars 10 forks source link

ic_read fails to read england-and-wales datetimes #15

Closed Robinlovelace closed 5 years ago

Robinlovelace commented 5 years ago

Reprex:

library(ical)
ics_file <- system.file("extdata", "england-and-wales.ics", package = "ical")
ic <- ic_read(ics_file)
ic
#> # A tibble: 65 x 6
#>    DTEND               DTSTART             SUMMARY  UID   SEQUENCE DTSTAMP
#>    <dttm>              <dttm>              <chr>    <chr> <chr>    <chr>  
#>  1 NA                  NA                  New Yea… ca6a… 0        201808…
#>  2 NA                  NA                  Good Fr… ca6a… 0        201808…
#>  3 NA                  NA                  Easter … ca6a… 0        201808…
#>  4 NA                  NA                  Early M… ca6a… 0        201808…
#>  5 NA                  NA                  Spring … ca6a… 0        201808…
#>  6 NA                  NA                  Queen’s… ca6a… 0        201808…
#>  7 NA                  NA                  Summer … ca6a… 0        201808…
#>  8 NA                  NA                  Christm… ca6a… 0        201808…
#>  9 NA                  NA                  Boxing … ca6a… 0        201808…
#> 10 NA                  NA                  New Yea… ca6a… 0        201808…
#> # ... with 55 more rows

Created on 2018-09-23 by the reprex package (v0.2.0).

Any ideas @layik ? I almost certainly broke this!

layik commented 5 years ago

Is this what we are expecting?

library(ical)
ics_file <- system.file("extdata", "england-and-wales.ics", package = "ical")
ic <- ic_read(ics_file)
ic
#> # A tibble: 65 x 6
#>    DTEND   DTSTART  SUMMARY        UID                 SEQUENCE DTSTAMP   
#>    <chr>   <chr>    <chr>          <chr>               <chr>    <chr>     
#>  1 201201… 20120102 New Year’s Day ca6af7456b0088abad… 0        20180806T…
#>  2 201204… 20120406 Good Friday    ca6af7456b0088abad… 0        20180806T…
#>  3 201204… 20120409 Easter Monday  ca6af7456b0088abad… 0        20180806T…
#>  4 201205… 20120507 Early May ban… ca6af7456b0088abad… 0        20180806T…
#>  5 201206… 20120604 Spring bank h… ca6af7456b0088abad… 0        20180806T…
#>  6 201206… 20120605 Queen’s Diamo… ca6af7456b0088abad… 0        20180806T…
#>  7 201208… 20120827 Summer bank h… ca6af7456b0088abad… 0        20180806T…
#>  8 201212… 20121225 Christmas Day  ca6af7456b0088abad… 0        20180806T…
#>  9 201212… 20121226 Boxing Day     ca6af7456b0088abad… 0        20180806T…
#> 10 201301… 20130101 New Year’s Day ca6af7456b0088abad… 0        20180806T…
#> # ... with 55 more rows

Created on 2018-09-23 by the reprex package (v0.2.0).