ATFutures / calendar

R interface to iCal (.ics files)
https://atfutures.github.io/calendar/
Other
41 stars 11 forks source link

Specify explicit integer params #20

Closed mpadge closed 6 years ago

mpadge commented 6 years ago

@Robinlovelace @layik This is just a good practice thing. Explicitly specifying integers by changing 1 to 1L will generally boost efficiency in vectorized operations, because the underlying C arrays will be allocated as the appropriate (and faster) type. Without this, they'll be float, and this can be less efficient. This is just an example, and there are likely other places whether this would be good to implement

Robinlovelace commented 6 years ago

And we're unlikely to need subsecond accuracy on our appointments hehe :+1:

layik commented 6 years ago

Thanks for the explanation @mpadge my journey through R is definitely one of pleasure by touching C! Will definitely look from this "pull request".