search

ATFutures / calendar

R interface to iCal (.ics files)
https://atfutures.github.io/calendar/
Other
41 stars 10 forks source link

Issue https://github.com/ATFutures/calendar/issues/57 fix :wrench: #58

Closed serkor1 closed 3 months ago

serkor1 commented 3 months ago

Hi,

I have created a new R-script called utils, which contains the assert()-function. For some devs this is the standard file to put these kind of helper-functions in - this is at least what I do :smile:

[!NOTE] I have only added the functionality to functions that already used a mix of stopifnot and stop. I haven't added this functionality on any other functions.

I found two typos that I have corrected also. See commit e63371e8787082c58ed5227b3236b2b5bc2b4f6c and 24c12111991becc56b4da14377f24188e440962e.

The dependency on {methods} are gone, and a new dependency on {cli} is made. The {methods}-package were only used in two functions. So I believe this was a good choice.

I have run devtools::check() and everything passes locally.

Best,

@serkor1

Robinlovelace commented 3 months ago

Great stuff, will take a look!

layik commented 3 months ago

Looks good to me. Any extra comments @layik, @mpadge or anyone else before merging? See comments from me @serkor1. Good work 🚀.

I am away so quick reply from me to say if it passes the tests (coverage of which I just checked is now deactivated on CodeCov) it is good enough for me. Thanks @serkor1 for the contribution.