ATFutures / geoplumber

Serve geographic data from R and consume with scalable front end.
https://atfutures.github.io/geoplumber/
59 stars 7 forks source link

GeoJSONComponent duplicated #32

Closed mpadge closed 6 years ago

mpadge commented 6 years ago

I see the following warning on gp_build():

Creating an optimized production build... [0/250]
Failed to compile.

./src/Welcome.js
Module build failed: Duplicate declaration "GeoJSONComponent"

   9 | import './App.css';
  10 | 
> 11 | import GeoJSONComponent from './components/GeoJSONComponent.jsx';
     |        ^
  12 | export default class Welcome extends Component {
  13 |     constructor(props) {
  14 |         super(props);

In ./inst/src/js/Welcome.js, you've got (current Line#7):

import GeoJSONComponent from './components/GeoJSONComponent.jsx';

and then in R/gp_add_geojson.R, you've also got two lines which construct an identical statement by default (current Line#31 and 47). The names of the imported objects for one of these statements should be changed to avoid this duplication.

layik commented 6 years ago

Thanks again Mark, will check test case and push.

layik commented 6 years ago

Clsoing this @mpadge. Reopen if not done properly.

mpadge commented 6 years ago

Great fix! Thanks