Closed Robinlovelace closed 6 years ago
Thanks @Robinlovelace will check it out.
Onto this
Great work on this @layik ! Following code works a treat:
library(geoplumber)
data(package = "geoplumber")
head(meta)
#> [1] "{"
#> [2] "\"type\": \"FeatureCollection\","
#> [3] "\"crs\": { \"type\": \"name\", \"properties\": { \"name\": \"urn:ogc:def:crs:OGC:1.3:CRS84\" } },"
#> [4] " "
#> [5] "\"features\": ["
#> [6] "{ \"type\": \"Feature\", \"properties\": { \"cp\": \"20MPH1\", \"road\": \"Kennington Road\", \"la_name\": \"LBS\", \"rcat\": \"LBS 20MPH monitoring\", \"easting\": 531209, \"northing\": 179142 }, \"geometry\": { \"type\": \"Point\", \"coordinates\": [ -0.11124, 51.49595 ] } },"
?meta
Created on 2018-08-31 by the reprex package (v0.2.0).
Next step I guess is to create examples, either in the README or in @examples
to show how functions work. Can't wait to see how this looks when served into a JS framework.
On a different note: please get ssh keys for GitHub. Will make pushing faster and make you appear as a contributor: https://help.github.com/articles/checking-for-existing-ssh-keys/
Thanks @Robinlovelace. Yes, thinking how "examples" should work in the context of this package!
RE keys, it was changing password on GH causing it, not a fan of SSH keys. I dont do them on my servers either. Keeps passwords fresh in my head. Reset my user.email and done.
Yay! I can see it's actually you committing code now :+1:
I suggest we add data on traffic counts (CDRC), crimes (ukpolice) and maybe stats19 data.
I think these will be most useful as documented R data objects, as described here: http://r-pkgs.had.co.nz/data.html
One question: should the package import sf? My vote: yes.