search

ATFutures / geoplumber

Serve geographic data from R and consume with scalable front end.
https://atfutures.github.io/geoplumber/
59 stars 7 forks source link

Vignettes slow down build #75

Closed layik closed 5 years ago

layik commented 5 years ago

They are valuable resources, whether they need to be rebuilt every time the package is built, I am just not sure anymore.

Robinlovelace commented 5 years ago

If it's an issue with local build times, you could use the flag --no-vignettes to not run R code in vignettes: https://support.rstudio.com/hc/en-us/articles/200486518-Customizing-Package-Build-Options

Another approach is to use eval = FALSE, something I do in this new stplanr vignette: https://ropensci.github.io/stplanr/articles/stplanr-od.html

It's annoying how long pkgs take to build and I've also wrestled with that question. Hope that helps...

layik commented 5 years ago

Maybe the same on Travis?

Thanks Robin. I think one of those would be good enough. I will see if I can push a commit.

Thanks Robin!

layik commented 5 years ago

https://github.com/ATFutures/geoplumber/commit/c06eab95309bb428fabe7c3873b971f28b6d8905 has made the build pass but midnight Travis took 32 mins.

layik commented 5 years ago

Closing pending other opts.