search

ATFutures / geoplumber

Serve geographic data from R and consume with scalable front end.
https://atfutures.github.io/geoplumber/
59 stars 7 forks source link

r_bg broken - again #83

Closed layik closed 3 years ago

layik commented 3 years ago

Previous work for gp_explore and others needed the use of callr, see Mark's first recommendation: https://github.com/ATFutures/geoplumber/issues/82#issuecomment-629850023

Since, various issues exist around the use of running processes in the background whilst having full control on the process to shut it down when done.

Current issue is that in gp_explore this no longer functions: 

f <- function(s, p) s$run(port = p) 
ps <- callr::r_bg(f, list(s = server, p = 8000)) # server being valid plumber instance
layik commented 3 years ago

https://github.com/rstudio/plumber/issues/451#issuecomment-707846947

layik commented 3 years ago

Thanks to @meztez this can now be taken care of and hopefully it is a lasting solution for geoplumber.

layik commented 3 years ago

All tests pass so should be good to close despite Travis still failing.