search

ATFutures / upthat

Urban planning and transport health assessment tool
4 stars 1 forks source link

Make flow numbers meaningful #14

Closed Robinlovelace closed 4 years ago

Robinlovelace commented 4 years ago

Currently the flow numbers are bamboozlingly big. We could modify them in-app but I think it would be better if the input data were updated so that they provide counts of trips per day. You up for doing that @mpadge for the Accra and Kathmandu as you have for NYC?

image

https://github.com/moveability/calibration/issues/7#issuecomment-552448603

mpadge commented 4 years ago

That's a part of the imminent plan - to use the NYC data to be able to scale the Accra and Kathmandu values to something real. And you're also right that the numbers actually are bamboozingly big - I'll check out what I've done there are rectify.

Edit: The main thing is that they are out by a factor that turns out to be 113 / 408,920, so if you just multiply all of them by that, you get roughly there - absolute maximal flows are then 166,000 in a day. This is still too high, but will be reduced to more realistic range in next iteration of main manuscript, because that will allow me to think about the scaling a bit better.

mpadge commented 4 years ago

ah shite, see this dodgr issue - there's something awry with the internal scaling of the spatial interaction models. I'll fix that tomorrow morning (it has to just be something trivial), but will then have to regenerate layers to get final values according to procedure i just described. (But that's all very easy now, and i can generate the bulk of the layers in just a few hours.)

mpadge commented 4 years ago

Done in latest version

Robinlovelace commented 4 years ago

Heads-up @mpadge I think this is still an issue: we should add units to layer heading. Also, the pedestrian counts in Accra and Kathmandu seem low. You happy for me to re-open? Will open a separate easy-to-fix ticket on rounding.

mpadge commented 4 years ago

This can and should stay closed, because the units are all meaningful now, excepting minor #24

Robinlovelace commented 4 years ago

Just to clarify, what are the units? Number of people passing on a segment per workday like in the PCT I guess. That should probably go into the legend.

mpadge commented 4 years ago

Yep, numbers of people per day

Robinlovelace commented 4 years ago

Per working day? Worth adding to the legend? Also it's worth adding info on the exposure layer, e.g. "Relative levels of pollution" or something more specific.

mpadge commented 4 years ago

I'll leave you to change legend titles, which is now fortunately easy with current PR. The "flows" layer are - yes, indeed! - numbers per working day, and the exposure layer is the HEAT-style "Relative Risk" of mortality scaled to total population, and so is "expected mortality". But we need to talk to WHO about exactly how best to interpret that. I'd suggest for the moment just calling it "expected mortality"?