search

ATFutures / upthat

Urban planning and transport health assessment tool
4 stars 1 forks source link

fixes #26 #27

Closed mpadge closed 4 years ago

mpadge commented 4 years ago

@SymbolixAU - yes, confirmation that your legend functions really are very useful and just work outta the box as one would expect. Thanks! My only suggestion would be for your code to be internally compatible with ... well, your code. What is mean is that i would expect to be able to submit

    cols <- colourvalues::get_palette ("inferno")

straight to legend_element, but instead i have to do the rbg conversion:

    cols <- rgb (colourvalues::get_palette ("inferno"), maxColorValue = 255)

Awesome stuff as always! :rocket:

Robinlovelace commented 4 years ago

Great to see the commits rolling in, will merge asap... Hoping this tab goes green!

Robinlovelace commented 4 years ago

I see this from the travis log:

https://travis-ci.org/ATFutures/upthat/builds/616678911#L2718

I think colourvalues needs to be added as an import if we use it in the package.

checking dependencies in R code ... WARNING

'::' or ':::' import not declared from: ‘colourvalues’

Good thing we've go CI going to pick up on these!

SymbolixAU commented 4 years ago

@mpadge There's also 

convert_colour( get_palette ("inferno") )
## or
colour_values( 1:256 )

But I suppose I could add a rgb = FALSE (or similar) argument into get_palette()