search

ATFutures / upthat

Urban planning and transport health assessment tool
4 stars 1 forks source link

Add jsonify dependency #53

Closed Robinlovelace closed 4 years ago

Robinlovelace commented 4 years ago

This seems to be required for dev version of mapdeck. Heads-up @symbolixAU

mpadge commented 4 years ago

Strange, that shouldn't be needed because it's just a LinkingTo, not an Imports. Is it just because travis needs it? (Although that's hard to tell at present because r-travis is failing in general.)

Robinlovelace commented 4 years ago

Try install_github("atfutures/upthat") - it fails without this for me.

mpadge commented 4 years ago

jsonify is just in LinkingTo of mapdeck, and so is automatically installed with mapdeck. I checked in a clean docker container, which came up with an auto-install of CRAN jsonify = 1.0.0, but a dependency of spatialwidget on jsonify >= 1.0.3. This means that current mapdeck needs a Remotes: jsonify, and so ping @SymbolixAU - can you please amend accordingly, or update CRAN jsonify to >= 1.0.3 - thanks!

SymbolixAU commented 4 years ago

like this (and this ) ?

mpadge commented 4 years ago

Perfect - thanks! @robinlovelace this PR should no longer be necessary, right?

Robinlovelace commented 4 years ago

Correct.