search

ATMartin / simple-modal-tutorial

3 stars 0 forks source link

Ember 2.0.0-beta.1: Cannot read property 'modal-main' of undefined #1

Closed alekspetrov closed 9 years ago

alekspetrov commented 9 years ago

Can't figure out how to make it work with ember.2.0.0-beta.1. This works just fine in Ember 1.11, after install ember beta cannot define property 'modal-main'. Did you try this great solution with ember beta?

ATMartin commented 9 years ago

I haven't tried it on beta yet, no. I'll see about making a new branch and moving it over soon, though - thanks for opening this issue!

alekspetrov commented 9 years ago

The trouble is that View removed in ember 1.13. I lost sight of it. But I can't figure out how to replace var modal = Ember.VIew.views[target] in ember 1.13.

Ref: http://emberjs.com/deprecations/v1.x/#toc_ember-view

ATMartin commented 9 years ago

http://blog.atmartin.io/a-simple-modal-for-ember-v2-component-edition/

ATMartin commented 9 years ago

Thanks again! :) New code is on branch ember2.