Open mcloughlin2 opened 4 months ago
Hi, I have tested the following so far mainly by using various tutorial notebooks and running the functions through there. I will update this in a bit when I am finished trying out the rest of the features.
Comments:
WARNING:tensorflow:From [/Users/apaulson/atomsci-venv/lib/python3.9/site-packages/tensorflow/python/util/deprecation.py:588](http://localhost:8888/lab/tree/repos/AMPL_umbrella/AMPL/atomsci/ddm/examples/tutorials/atomsci-venv/lib/python3.9/site-packages/tensorflow/python/util/deprecation.py#line=587): calling function (from tensorflow.python.eager.polymorphic_function.polymorphic_function) with experimental_relax_shapes is deprecated and will be removed in a future version.
Instructions for updating:
experimental_relax_shapes is deprecated, use reduce_retracing instead
_generate_scaffold_dist_matrix
, far_frac_fitness
)Comments:
plot_split_diagnostics()
is great. I would recommend moving the tanimoto distance distribution plots to the end with the unweighted fitness scores. That way, all things that are per-task are plotted first and the user can specify num_cols=num_tasks
for a neater plot.plot_split_fractions()
and plot_fitness_terms()
. You can just do a simple if axes is None: fig, ax = plt.subplots()
check.
Improvements to MultitaskScaffoldSplitter:
New module split_diagnostic_plots:
Sparsity-related parameters for XGBoost models:
New search domain parameters for hyperopt optimization of sparsity parameters:
Feature_importance function to draw line plot of summed NN absolute feature weights vs epoch.